OSD600 4.0 Telescope update


In the week, I fixed one external issue and keep working on the internal issue.
External:
AncientBeast is a website game that you can play on you laptop and your phone I fixed an issue for UI from a game. Below is how the page looks like in website. As we can see, there is padding in left and right side.

Here is the web looks like in phone. As we can see, the is no left and right padding. As the member for this project, he/she wants the page looks the same whatever it's in desktop or phone.

Issue: No div side padding
Pull request: Fix issue#97 removed padding
Conclusion:
This project is using php to build it. They use nvm (Node Version Manager).
When I decided to fix this issue, I was thinking it was not different issue. Just change padding to 0 should be work. However, after I stepped into the project, problem came out. They use iframe. I cannot just remove padding cause they didn't set up the padding, They limit the size of the iframe. I need to rest the width to 100% to meet the requirement. Finally, I fixed it. In this issue, I spent more time on set up the environment. Setting up environment is my weak, I should learn more.

Internal:
I keep working on the internal issue. For the pull request #332, I failed the checking. After class, I knew I need to do the rebase. When I did the rebase, more problem came out. I asked for my classmate help. I am so happy many students in my class help me to fix it. I found I used the wrong branch name in my local, so I tried to changed the name. However, this will effect the pull request I submitted before. It will close the old issue and I have to create a new pull request.
Issue: Allow a post to get stored in Redis
Old pull request: #332 implement getPost and addPost method
New pull request: #369 implement addPost and getPost

Finally, everything passed and it was merged to the master.  After around half an hour, someone filed an issue assign for Tony and me. I though it happened where I did rebase.

Issue: #374 Duplicated file storage.js
Pull request: #376 removed storage.js under src

Conclusion: As a team to work together, time manager is important cause someone might need the method you created to finish own part. If you have any question, you have to ask for help don't stop there.



Previous: OSD600 4.0 Telescope Contribute


Comments

Post a Comment

Popular posts from this blog

2nd pull request for Hacktoberfest

Image
I fixed two more small issues to practice how to use GitHub. The first one is using Python.This is a good opportunity for me to learn a new language -- Python . The second one is fixing the layout. After I fixed it, I got the invitation from the organization. Issue: update the copyright to 2019 . Here is the pull request of it: Here is the issue of fixing page layout : Here is the pull request : Conclusion: After I fixed some issues from GitHub, I found I like it. Even though I spent a lot of time to do it. But I learned so much such as set up the environment to run a project. Some project using Docker, Chrome developer tool. It's all new for me. Fixing issue is a good way for me to keep learning new stuff. Keep improving in the future. Previous:  1st pull request for Hacktoberfest
Read more

OSD600 Release 3.0 Telescope

Image
Introduction Telescope is a tool for tracking Seneca's open source involvement.  However, this website was built long time ago. Click here then you can visit the telescope we are using so far. For the release 3.0, we are going to refactor the website together with 50+ students using the popular tool and language. When I heard that I was so exited cause I have chance to use the knowledge I learn so far. However, after the first class of discuss what we should use to build it. I felt so confuse.  I don't even know how I can step into the project.  Here is the telescope GitHub.  I forked and cloned the project for the first step. You can check my Release1.0 , there is a detail instruction of how I started working on a project.  Prerequisites: Node.js (npm) Redis is an in-memory data structure store but I have never heard it before. I decided to learn it first.  Download Redis from here . And install it follow the installation. Problem I forked the project many d
Read more

Introduction of Karla

I am totally new to learn open source in this semester. This is the first blog I wrote, hopefully it will become better in the future. I am a programmer who has knowledge in different programming language such as C/C#/C++, Java, Swift, Javascript and Typescript. I have more knowledge in Angular from my work experience. I am interested in creating some small game, webpage, app for IOS and Android. This blog is used to record the experience of my study in open source. Hopefully my experience is useful for the learner like me.
Read more