1st pull request for Hacktoberfest

This is the first pull request I did for Hacktoberfest.
1. Look for the issue from the GitHub, there are so many issues there.
Here are some link I used:
Follow the 
  1. Fork the repositories: opendataday
  2. Clone it from your own github to your local.

       3. Create new branch using: git checkout -b newBranchName. This will create new branch name newBranceName and point the HEAD to it. Never work on the master
        4. Open the code and fix the issue.
        5. git add . to add all the code you changed.
        6. git commit -m "fix issue of the brance " 
        7. git push origin newBranceName
        8. create pull request.

Here is the issue:
Improve Layout on small displays

Here is the pull request:

issue20 improve layout on small displays #21


Conclusion: 
To fix this issue, I learned a lot.
1.  I learned how to use Docker to run it. 
2.  Remember don't work on the master.
3.  Turn off the auto format when it saved.
4. use code . command to open visual code.





Previous: Hacktoberfest2019 is coming 



Comments

Post a Comment

Popular posts from this blog

OSD600 4.0 Telescope contribute

Image
In the 3.0 I created a function to count blog posts from different domain and created tester to test it collaborate with my classmate.  Here is what we did in 3.0. In the 4.0, we decided to work together again. We picked two issue from the list. Issue 1: #260 Allow a Post to get stored in Redis. Issue2: #261 Update frontend design to include all Post data. To finish the 4.0, one internal pull request has to be merged and fixed one external issue. we have around three weeks to finish it. So we decided to focus on the fist issue in this week. Pull request 1: #332 Fix #260 implement addPost and getPost method I checked the code my professor created for getFeed and getFeeds method in storage.js. I was so surprised  that he only use around 10 lines to do it. I need to understand what this code is doing.  To understand his code, I have know what the method is it. Even though I discussed it with my collaborator, we didn't fully understand it. However, my professor ex...
Read more

OSD600 Release 3.0 Telescope

Image
Introduction Telescope is a tool for tracking Seneca's open source involvement.  However, this website was built long time ago. Click here then you can visit the telescope we are using so far. For the release 3.0, we are going to refactor the website together with 50+ students using the popular tool and language. When I heard that I was so exited cause I have chance to use the knowledge I learn so far. However, after the first class of discuss what we should use to build it. I felt so confuse.  I don't even know how I can step into the project.  Here is the telescope GitHub.  I forked and cloned the project for the first step. You can check my Release1.0 , there is a detail instruction of how I started working on a project.  Prerequisites: Node.js (npm) Redis is an in-memory data structure store but I have never heard it before. I decided to learn it first.  Download Redis from here . And install it follow the installation. Problem I fork...
Read more

OSD600 3.0 Telescopen update

Image
As I mention in the previous blog, we are going to contribute to telescope.  Click here to see the GitHub. I checked the issues that we have so far and cannot find any issues that I can work on. So I discussed with my classmate and create the issues for us. After our discussion, We decided to make a function to count how many blog come from different domain. Issue --   Implement blog post count by domain .  Click here to check the pull request. Issue -- Test the function of counting each domain post . Click  here  to check the pull request. Issue -- Updarte blogDomainCounter to pass tester Click  here  to check the pull request. When we discussed to make the function to count it, we though it should be done soon cause it was not so difficult. However, when we actually open a file and started working on it. we met so many problem such as: 1. How we can get the urls. 2. How to get the domain. I read all the code we had so far and unde...
Read more